Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower MIN_Z_FOR_UNLOAD #4750

Merged

Conversation

sarusani
Copy link
Contributor

@sarusani sarusani commented Aug 9, 2024

Lower the amount of Z lift on filament unload from 50mm to 10mm 20mm.

This does not alter the behavior of M600. (M600 uses MIN_Z_FOR_SWAP)

Resolves #4700

Copy link

github-actions bot commented Aug 9, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 247736 5653 6216 2539
MK3_MULTILANG 0 0 247050 5662 6902 2530

Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

@3d-gussner
Copy link
Collaborator

3d-gussner commented Aug 14, 2024

@sarusani @gudnimg Please see my comment #4700 (comment)

Please test the described issue as I couldn't reproduce it.

This PR changes the Unload height to +10mm after a start or reset, this is in my opinion too close to the bed.

@sarusani
Copy link
Contributor Author

sarusani commented Aug 14, 2024

I just assumed that what's he doing. You're right, it can only happen after a reset/reboot. I chose 10mm because that's also used for preheating, so I used the closest save distance. I personally use 25mm on my printer.

@3d-gussner
Copy link
Collaborator

Looking at Buddy firmware they use 20mm https://github.com/search?q=repo%3Aprusa3d%2FPrusa-Firmware-Buddy%20Z_AXIS_UNLOAD_POS&type=code maybe we can "sync" that value.

@sarusani
Copy link
Contributor Author

Yes, I think that makes sense. 👍

Sync value with Buddy firmware
@sarusani sarusani force-pushed the LessZAxisMovementOnManualFilamentUnload branch from bed02a1 to d3f2dce Compare August 14, 2024 10:09
@3d-gussner 3d-gussner added this to the FW 3.14.1 milestone Aug 14, 2024
@3d-gussner 3d-gussner merged commit 21fc1dd into prusa3d:MK3 Aug 14, 2024
4 checks passed
@sarusani sarusani deleted the LessZAxisMovementOnManualFilamentUnload branch August 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Z axes is going up after Unload filament is selected
3 participants