Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup of dead UART2 code #4816

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Minor cleanup of dead UART2 code #4816

merged 5 commits into from
Nov 27, 2024

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Nov 24, 2024

No description provided.

@gudnimg gudnimg requested review from leptun and 3d-gussner November 24, 2024 09:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 248302 5654 5650 2538
MK3_MULTILANG 0 0 247672 5663 6280 2529

@leptun
Copy link
Collaborator

leptun commented Nov 24, 2024

Don't see any issues with the PR. Gonna test it on a printer tonight and approve and merge if everything works.

leptun
leptun approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@leptun leptun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with MK404 and it seems to be working just like before. So approving
Side note, MK404 seems to have the MMU2 emulation broken since the startup selftest fails. But the communication between the boards works just like before

3d-gussner
3d-gussner approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested MK404

  • MK3S
    • PrusaLink 0.81 and PrusaConnect
    • OctoPrint 1.10.3
  • MK3S with MMU
    • PrusaLink 0.81 and PrusaConnect
    • OctoPrint 1.10.3
  • MK2.5S
    • PrusaLink 0.81 and PrusaConnect
    • OctoPrint 1.10.3

All communication between printer and MMU and host systems without any issues.

@3d-gussner 3d-gussner merged commit d3f9559 into prusa3d:MK3 Nov 27, 2024
4 checks passed
@gudnimg gudnimg deleted the uart_cleanup_gudni branch November 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3d-gussner 3d-gussner 3d-gussner approved these changes

@leptun leptun leptun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gudnimg @leptun @3d-gussner