Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7-alpha1 skips leading zero on G2 J/I parameters for legacy marlin machines (Snapmaker A350) #11620

Closed
2 tasks done
tyeth opened this issue Nov 8, 2023 · 7 comments
Closed
2 tasks done

Comments

@tyeth
Copy link

tyeth commented Nov 8, 2023

Description of the bug

Legacy Marlin Machine doesn't like instruction that is missing leading zero. Using official printer profile for Snapmaker A350 supplied by Prusa as part of PrusaSlicer 2.7.0-alpha1
e.g.
G2 X186.82 Y226.366 I.037 J-.212 E33.22049

Project file & How to reproduce

FrameAndVentPETG_A350.zip
Printer pauses at inner walls here in mid section of model (90 degree bend) which appears to use the G2 move for inner walls.
Screenshot 2023-11-08 181210

Checklist of files included above

  • Project file
  • Screenshot

Version of PrusaSlicer

2.7.0-alpha1

Operating system

win11 64

Printer model

Snapmaker A350

@neophyl
Copy link

neophyl commented Nov 8, 2023

This is a duplicate issue. Its been raised before. Please see #7505 or #6996

In particular this comment #6996 (comment)

@tyeth
Copy link
Author

tyeth commented Nov 8, 2023

If a regex is needed to fix printer profiles that Prusa supply (yes for other manufacturers) to fix known faults, then include it in the profile.

It's a bug, Prusa just chooses Won't fix.
See #7505 (comment)

If users can submit patches for the profiles then let me know what key would achieve that regex, but to be honest it feels like bodge to make every user of an officially supplied printer profile add a regex manually to fix a known issue with that profile.

As far as marlin2 and klipper go, that's fine, they've got a modern spec and systems designed for powerful string processing, but devices using legacy marlin have a good chance of breaking with any quirks of convenience (like dropping leading zero).

@neophyl
Copy link

neophyl commented Nov 8, 2023

Profiles for non Prusa machines are submitted by users. There’s another repo for those but I don’t know what the process is for submitting to it. I’ve seen other issues here where one of the devs has pinged someone else when profile issues come up for other machines though.

@tyeth
Copy link
Author

tyeth commented Nov 8, 2023

Thanks neophyl, I could and should have done this years ago. PR submitted after copying from my exported settings bundle.

@rtyr
Copy link
Collaborator

rtyr commented Nov 8, 2023

Using official printer profile for Snapmaker A350 supplied by Prusa as part of PrusaSlicer 2.7.0-alpha1

G2/G3 commands are emitted only with arc fitting enabled. It is not enabled in bundled profiles and it may be not good idea to enable it for printers with old Marlin (various bugs in arc implementation).

Do you have any issues without arc fitting enabled?

@tyeth
Copy link
Author

tyeth commented Nov 8, 2023 via email

@rtyr
Copy link
Collaborator

rtyr commented Nov 10, 2023

PR was merged and distributed via configuration update 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants