Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit M486 A line length #13314

Closed
DerMouse opened this issue Aug 30, 2024 · 5 comments
Closed

Limit M486 A line length #13314

DerMouse opened this issue Aug 30, 2024 · 5 comments

Comments

@DerMouse
Copy link

DerMouse commented Aug 30, 2024

When slicing some STL with a very long file name, the M486 A lines written by PrusaSlicer will trigger a printer reboot when sent through firmware side checksum validation. Problem is discussed here :

prusa3d/Prusa-Firmware-Buddy#4123
prusa3d/Prusa-Firmware-Buddy#4123 (comment)
prusa3d/Prusa-Firmware-Buddy#4123 (comment)

The slicer should at least warn the user if the sliced filename is too long, or truncate/shorten the file name in the M486 line. This will avoid triggering the problem for the normal user.

@foosel

This comment was marked as outdated.

@DerMouse

This comment was marked as outdated.

@Jan-Soustruznik
Copy link
Collaborator

Hello, @DerMouse , What maximum limit of the name is expected? Thank you

@DerMouse
Copy link
Author

DerMouse commented Oct 8, 2024

Hello, @DerMouse , What maximum limit of the name is expected? Thank you

Hello Jan. Since the M486 lines written by PrusaSlicer use the sliced filename, theoretically the sky is (almost) the limit. But I guess that, reasonably, something around 50-60 chars should be good (who in his right mind has filenames consistently longer than 60 chars, except me and this was a very very edge-case ?)

@FidelCapo
Copy link
Collaborator

This issue should be fixed in version 2.9.0-beta1.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants