Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Previous Block Root From State instead of Saved Block #1980

Closed
nisdas opened this issue Mar 13, 2019 · 2 comments
Closed

Use Previous Block Root From State instead of Saved Block #1980

nisdas opened this issue Mar 13, 2019 · 2 comments
Labels
Bug Something isn't working

Comments

@nisdas
Copy link
Member

nisdas commented Mar 13, 2019

Currently we retrieve the chain head and hash it to generate the previous block root for state transitions. We should instead be using the previous block root from the state. This would solve some edge cases for us in sync. Ref: ethereum/consensus-specs#692 (comment)
@nisdas nisdas added the Bug Something isn't working label Mar 13, 2019
@nisdas nisdas mentioned this issue Mar 15, 2019
Closed
@prestonvanloon
Copy link
Member

@rauljordan can you add a comment why this should be closed? Please reference commit or PR.

@rauljordan
Copy link
Contributor

This has been fixed by #2003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get Previous Block Root From State prysmaticlabs/prysm
3 participants
@rauljordan @prestonvanloon @nisdas