Get Previous Block Root From State #2003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
rauljordan,
0xKiwi,
prestonvanloon and
terencechain
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
======================================
Coverage 69.9% 69.9%
======================================
Files 112 112
Lines 8814 8814
======================================
Hits 6161 6161
Misses 2036 2036
Partials 617 617 |
terencechain
approved these changes
Mar 15, 2019
beacon-chain/blockchain/service.go
Outdated
| @@ -8,6 +8,8 @@ import ( | |||
| "fmt" | |||
| "time" | |||
|
|
|||
| "github.com/prysmaticlabs/prysm/shared/bytesutil" | |||
|
|
|||
There was a problem hiding this comment.
we should remove the spacing here? stupid IDE... 😞
rauljordan
approved these changes
Mar 15, 2019
…o getHeadFromState
…eth-sharding into getHeadFromState
|
Don't Merge this in yet, its dependent on #2006 getting merged in first |
| func (c *ChainService) ChainHeadRoot() ([32]byte, error) { | ||
| head, err := c.beaconDB.ChainHead() | ||
| func (c *ChainService) ChainHeadRoot(state *pb.BeaconState) ([32]byte, error) { | ||
| root, err := b.BlockRoot(state, state.Slot-1) |
There was a problem hiding this comment.
we should be careful of this, imagine the following the scenario:
validator current time: 25s
beacon node state slot: 3
Beacon node has just processed the head for slot 3, validator wants whatever the head is at slot 3 but given state.Slot-1, validator can only get the block root at slot 2 but it should be 3
There was a problem hiding this comment.
Hey @nisdas is this still relevant?
|
Not relevant anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1980, where we retrieve block root from the state instead of performing a read for it from the db. This also resolves issues with initial sync in the case of skipped slots.