Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types Tests Fail With Race Detection #604

Closed
terencechain opened this issue Oct 2, 2018 · 4 comments
Closed

Types Tests Fail With Race Detection #604

terencechain opened this issue Oct 2, 2018 · 4 comments
Assignees
@rawfalafel
Labels
Bug Something isn't working

Comments

@terencechain
Copy link
Member

Types tests failed with race detection on in Travis and we have turned race detection off in types tests package. Opened this issue to investigate why it was failing with race on and how to resolve it.

https://travis-ci.org/prysmaticlabs/prysm/jobs/436267953
@terencechain terencechain added the Bug Something isn't working label Oct 2, 2018
@rawfalafel
Copy link
Contributor

The most suspicious part is the IO logic here. Can we test this theory by turning race back on and uncommenting TestInitGenesisJson?

@rawfalafel rawfalafel mentioned this issue Oct 5, 2018
Closed
@prestonvanloon prestonvanloon added this to the Backlog milestone Oct 9, 2018
@rawfalafel
Copy link
Contributor

Resolved in #636

@terencechain
Copy link
Member Author

Looks like this is still there. Reopening

@terencechain terencechain reopened this Oct 10, 2018
@nisdas nisdas mentioned this issue Oct 10, 2018
Merged
3 tasks
@rauljordan
Copy link
Contributor

Fixed in #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawfalafel rawfalafel

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rawfalafel @rauljordan @prestonvanloon @terencechain