Refactor More Casper Functions Into Beacon-Chain/Core #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
terencechain,
nisdas,
prestonvanloon and
rawfalafel
terencechain
approved these changes
Nov 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
=========================================
- Coverage 73.08% 72.5% -0.58%
=========================================
Files 69 69
Lines 4559 4554 -5
=========================================
- Hits 3332 3302 -30
- Misses 897 923 +26
+ Partials 330 329 -1 |
|
Cannot check if master works yet until #669 is merged |
…sm into refactor-state-transition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #781.
Description
This PR splits up more of the casper functions into pure packages as part of the beacon-chain/core API refactor. This splits up functions into files they pertain to more effectively, such as making it very clear that certain functions are specifically for calculating rewards/penalties while others are for validator interactions.