Allow Initial Sync to Work with Simulator #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
In Progress
Priority: Medium
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
==========================================
- Coverage 73.59% 73.22% -0.38%
==========================================
Files 67 69 +2
Lines 4367 4575 +208
==========================================
+ Hits 3214 3350 +136
- Misses 835 895 +60
- Partials 318 330 +12 |
nisdas
added
Priority: High
|
@nisdas sorry there are a few more issues. Looking at the run log from your last commit, BlockChain service never ran. After slot 5, it's only p2p service and simulator. Here is the normal log: |
|
Blocked by #787 |
|
Lint issues: |
terencechain
approved these changes
Nov 21, 2018
| @@ -44,8 +46,9 @@ type Config struct { | |||
| // CrystallizedStateBufferSize determines the buffer size of thhe `crystallizedStateBuf` channel. | |||
| func DefaultConfig() Config { | |||
| return Config{ | |||
| SyncPollingInterval: 1 * time.Second, | |||
| SyncPollingInterval: time.Duration(int64(params.BeaconConfig().SlotDuration)) * time.Second * 4, | |||
There was a problem hiding this comment.
What is this constant 4? Can we predefined this constant?
There was a problem hiding this comment.
Fixed into a config var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow initial sync to function with a simulator. By allowing the simulator to respond to requests by block slot number instead of block hash it will allow a node to be able to sync up to the latest chain head. This should also help to close out #661.