-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Sync Service to Query State Of Network #787
Conversation
… into networkSync
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
- Coverage 73.65% 73.41% -0.24%
==========================================
Files 66 67 +1
Lines 4217 4322 +105
==========================================
+ Hits 3106 3173 +67
- Misses 807 841 +34
- Partials 304 308 +4 |
… into networkSync
… into networkSync
…into networkSync
I'm experiencing some issues when running the command three times. Run the following command for about 15 seconds then kill the process with bazel run //beacon-chain -- --datadir=/tmp/data1 --rpc-port 4000 --genesis-json=$(pwd)/genesis.json --simulator --demo-config Do this twice, on the third attempt, you will see the follow errors:
On the 4th attempt, I see
These might be out of scope, but we should identify issues for these if we haven't already. |
… into networkSync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DIscussed offline that the issues I outlined are addressed in the other pull request #669.
Thanks!
Resolves #555, #661, #743
This allows the sync service to query peers in the network to find out their current head and determine if they are synced or not.
IsSynced
method, which will allow the node to know whether to begin initial sync or normal sync.