Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "IsSynced" method to determine sync status of node #661

Closed
rawfalafel opened this issue Oct 15, 2018 · 2 comments
Closed

Implement "IsSynced" method to determine sync status of node #661

rawfalafel opened this issue Oct 15, 2018 · 2 comments

Comments

@rawfalafel
Copy link
Contributor

rawfalafel commented Oct 15, 2018 •
edited
Loading

Currently, sync/service.go and initial-sync/service.go determines the sync status of the node (in relation to the network) by calling db.HasStoredState().

db.HasStoredState() only determines whether or not the local database has been initialized, not whether or not the local chain is caught up with the current chain. Therefore, we should replace HasStoredState with a new method IsSynced which surveys peers in the network.
@rawfalafel rawfalafel changed the title Implement "HasSynced" method to determine sync status of node Implement "IsSynced" method to determine sync status of node Oct 15, 2018
@rawfalafel
Copy link
Contributor Author

As a first step, I'm going to open up a preliminary PR to replaced db.HasStoredState with a stub for IsSynced. Merging that PR will allow #426 and #555 to be closed out.

@rawfalafel rawfalafel mentioned this issue Oct 15, 2018
Merged
@nisdas nisdas mentioned this issue Oct 17, 2018
Merged
3 tasks
@nisdas nisdas mentioned this issue Nov 16, 2018
Merged
3 tasks
@nisdas
Copy link
Member

nisdas commented Nov 19, 2018

Closed by #787

@nisdas nisdas closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rawfalafel @nisdas