Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced HasStoredState with IsSyncedWithNetwork #662

Merged
merged 3 commits into from
Oct 15, 2018

Conversation

rawfalafel
Copy link
Contributor

See this comment for more background.

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #662 into master will increase coverage by 0.8%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #662     +/-   ##
=========================================
+ Coverage   74.14%   74.94%   +0.8%     
=========================================
  Files          55       55             
  Lines        3508     3497     -11     
=========================================
+ Hits         2601     2621     +20     
+ Misses        682      653     -29     
+ Partials      225      223      -2
Impacted Files Coverage Δ
beacon-chain/db/state.go 75% <ø> (+17.85%) ⬆️
beacon-chain/sync/service.go 66.45% <100%> (+4.03%) ⬆️
beacon-chain/sync/initial-sync/service.go 77.27% <100%> (+14.11%) ⬆️
beacon-chain/rpc/service.go 77.29% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5117e6d...e846c01. Read the comment docs.

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rawfalafel rawfalafel merged commit 1f00cfe into prysmaticlabs:master Oct 15, 2018
@rawfalafel rawfalafel deleted the is-synced-stub branch October 15, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants