Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DepositParametersRecord to protobuf types #1042

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Add DepositParametersRecord to protobuf types #1042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f21d7a
Add DepositParametersRecord
prestonvanloon Dec 4, 2018
9981f91
_hash32
prestonvanloon Dec 4, 2018
d08774d
Merge branch 'master' into Add-DepositParametersRecord
rauljordan Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions proto/beacon/p2p/v1/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

syntax = "proto3";

package ethereum.beacon.p2p.v1;
Expand Down Expand Up @@ -94,7 +93,7 @@ message AttestationData {
message ValidatorRecord {
bytes pubkey = 1;
// TODO(781): The usage of withdrawal_credentials is not defined in spec. Not used in Prysm yet.
bytes withdrawal_credentials = 2;
bytes withdrawal_credentials = 2; // TODO(781): this is hash32, rename with suffix _hash32
bytes randao_commitment_hash32 = 3;
uint64 randao_skips = 4;
// Balance in Gwei
Expand Down Expand Up @@ -178,3 +177,11 @@ message BeaconBlock {
// All fields must be annotated with [deprecated=true];
google.protobuf.Timestamp timestamp = 1006 [deprecated=true]; // Keeping this until we refactor block validation.
}

message DepositParametersRecord {
bytes pubkey = 1;
bytes proof_of_possession = 2; // Type of ['uint384']??
// TODO(781): The usage of withdrawal_credentials is not defined in spec. Not used in Prysm yet.
bytes withdrawal_credentials_hash32 = 3;
bytes randao_commitment_hash32 = 4;
}