Remove Deprecated Spec Logic #1138
Conversation
| // The node has processed its state up to slot, block.slot - 1. | ||
| // The Ethereum 1.0 block pointed to by the state.processed_pow_receipt_root has been processed and accepted. | ||
| // The node's local clock time is greater than or equal to state.genesis_time + block.slot * SLOT_DURATION. | ||
| func IsValidBlock( |
There was a problem hiding this comment.
Is this new or just moved from somewhere else?
There was a problem hiding this comment.
Moved to core/blocks/validity_conditions.go - it was previously in state
| // Pre-Processing Condition 3: | ||
| // The block pointed to by the state in state.processed_pow_receipt_root has | ||
| // been processed in the ETH 1.0 chain. | ||
| if powBlock == nil { |
There was a problem hiding this comment.
Are we going to do something more with this block? Why do we get the whole block rather than some method like
b, err := doesPoWBlockExist(...)
if !b {
// fail
}There was a problem hiding this comment.
We might - I think the research around receipt processing is still a little in flux, so let's leave this for now or modify in another PR if needed - this one is just focused on removing fully deprecated code
|
If those methods in Terence's comment are truly unused, please delete. Yay for deleting code :) |
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
+ Coverage 72.12% 73.07% +0.94%
==========================================
Files 83 82 -1
Lines 5522 5111 -411
==========================================
- Hits 3983 3735 -248
+ Misses 1194 1058 -136
+ Partials 345 318 -27 |
This is part of #781.
Description
Now that our codebase is getting closer to being aligned with the specification here, we can now delete deprecated methods without causing our runtime to panic or causing build failures through Bazel.
This removes: