-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Attestation Type Primitive With Proto Generated Type #1149
Replace Attestation Type Primitive With Proto Generated Type #1149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
- Coverage 73.26% 72.64% -0.62%
==========================================
Files 82 82
Lines 5158 5111 -47
==========================================
- Hits 3779 3713 -66
- Misses 1056 1076 +20
+ Partials 323 322 -1 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More deletions than additions. My type of PR 😁
Looks good! Maybe mention you have deprecated AggregatedAtteststion proto in the description
This is part of #781
Description
This PR replaces all instances of primitives such as
*types.Attestation
with its corresponding protopb.Attestation
andpb.AttestationData
and also as a Golang struct if they are mostly 1-to-1 (the Go structs only having getters and setters). As such, we will enforce using the proto generated types throughout the repo.This PR deprecates all instances of AggregatedAttestation