Remove withdrawal Queue #11610
Merged
Remove withdrawal Queue #11610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
Nov 3, 2022
| // clonedAtts[i] = stateTrie.CopyAttestation(a) | ||
| // } | ||
| // aggregatedAtts, err := attaggregation.Aggregate(clonedAtts) | ||
| // clonedAtts := make([]*ethpb.Attestation, len(atts)) |
There was a problem hiding this comment.
why does your PR always do this?
There was a problem hiding this comment.
have no clue, I just run update-go-pbs
There was a problem hiding this comment.
That's weird. Our ./hack/update-go-pbs.sh don't do this. Hopefully we don't mess the next person up
terencechain
reviewed
Nov 3, 2022
| nextWithdrawalIndex uint64 `ssz-gen:"true"` | ||
| nextPartialWithdrawalValidatorIndex eth2types.ValidatorIndex `ssz-gen:"true"` | ||
| lastWithdrawalValidatorIndex eth2types.ValidatorIndex `ssz-gen:"true"` |
There was a problem hiding this comment.
I think we can remove ssz-gen:"true", it's probably better to do it in another PR
rauljordan
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the beacon state for Capella as per ethereum/consensus-specs#3068