-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiarch docker containers #12428
Multiarch docker containers #12428
Conversation
c9d1a15
to
b8fd93e
Compare
Still blocked by bazel-contrib/rules_oci#292 |
With e948da3, I think we can say we are unblocked and merge. If build times increase significantly then we may have to revert this PR. The flag removed only matters when fetching dependencies where it would hit an internal endpoint before reaching the external network. In theory, it shouldn't be much different but possibly an issue. I propose that we review this PR and merge targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanations
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This uses OCI manifest format (previously docker v2).
Features:
Which issues(s) does this PR fix?
Fixes #4900
Other notes for review
Depends on #12135, review and merge that first for clean diff.A follow up PR will provide the following changes: