Update holesky config for new genesis #12919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
prestonvanloon
force-pushed
the
new-holesky-genesis
branch
from
eaa92e6
to
0fbfe6b
Compare
prestonvanloon
added
Ready For Review
Comment on lines
-26
to
+38
| cfg.GenesisForkVersion = []byte{0x00, 0x01, 0x70, 0x00} | ||
| cfg.GenesisForkVersion = []byte{0x01, 0x01, 0x70, 0x00} | ||
| cfg.SecondsPerETH1Block = 14 | ||
| cfg.DepositChainID = 17000 | ||
| cfg.DepositNetworkID = 17000 | ||
| cfg.AltairForkEpoch = 0 | ||
| cfg.AltairForkVersion = []byte{0x10, 0x1, 0x70, 0x0} | ||
| cfg.AltairForkVersion = []byte{0x2, 0x1, 0x70, 0x0} | ||
| cfg.BellatrixForkEpoch = 0 | ||
| cfg.BellatrixForkVersion = []byte{0x20, 0x1, 0x70, 0x0} | ||
| cfg.BellatrixForkVersion = []byte{0x3, 0x1, 0x70, 0x0} | ||
| cfg.CapellaForkEpoch = 256 | ||
| cfg.CapellaForkVersion = []byte{0x30, 0x1, 0x70, 0x0} | ||
| cfg.CapellaForkVersion = []byte{0x4, 0x1, 0x70, 0x0} |
There was a problem hiding this comment.
there are the diffs, do they seem right?
terencechain
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Last testnet launch was borked due to misconfiguration. An entirely new genesis is required and the
fork versions have changed.
Which issues(s) does this PR fix?
Fixes #12724
Other notes for review
Do not merge until eth-clients/holesky#73 is merged.