Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few minor nits in protobuf definitions #13512

Merged
merged 1 commit into from
Feb 6, 2024
+8 −6
Merged

Fix a few minor nits in protobuf definitions #13512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions proto/engine/v1/execution_engine.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,15 +215,17 @@ message Withdrawal {
message BlobsBundle {
// The KZG commitments of the blobs.
repeated bytes kzg_commitments = 1 [(ethereum.eth.ext.ssz_size) = "?,48", (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size"];

// The proofs of the blobs.
repeated bytes proofs = 2 [(ethereum.eth.ext.ssz_size) = "?,48", (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size"];

// The blobs itself.
repeated bytes blobs = 3 [(ethereum.eth.ext.ssz_size) = "?,131072", (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size"];
repeated bytes blobs = 3 [(ethereum.eth.ext.ssz_size) = "?,blob.size", (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size"];
}

// Blob contains the data that is to be committed on chain.
message Blob {
// Each blob consists of `BLS_FIELD_ELEMENT`(32) multiplies `FIELD_ELEMENTS_PER_BLOB`(4096)
// The blob bytes.
bytes data = 1 [(ethereum.eth.ext.ssz_size) = "blob.size"];
}

Expand Down
4 changes: 2 additions & 2 deletions proto/eth/v2/beacon_block.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ message BeaconBlockBodyBellatrix {
// At most MAX_VOLUNTARY_EXITS.
repeated v1.SignedVoluntaryExit voluntary_exits = 8 [(ethereum.eth.ext.ssz_max) = "16"];

// Sync aggregate object to track sync committee votes for light client support.
// Sync aggregate object to track sync committee votes for light client support.
v1.SyncAggregate sync_aggregate = 9;

// Execution payload: the embedded execution payload of the block [New in Bellatrix]
Expand Down Expand Up @@ -523,7 +523,7 @@ message BeaconBlockBodyDeneb {
// At most MAX_BLS_TO_EXECUTION_CHANGES. New in Capella network upgrade.
repeated SignedBLSToExecutionChange bls_to_execution_changes = 11 [(ethereum.eth.ext.ssz_max) = "16"];

// At most MAX_BLOBS_PER_BLOCK. New in Deneb network upgrade.
// At most MAX_BLOB_COMMITMENTS_PER_BLOCK. New in Deneb network upgrade.
repeated bytes blob_kzg_commitments = 12 [(ethereum.eth.ext.ssz_size) = "?,48", (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size"];
}

Expand Down
2 changes: 1 addition & 1 deletion proto/prysm/v1alpha1/beacon_block.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ message BlindedBeaconBlockBodyDeneb {
// Execution payload header from the execution chain. New in Bellatrix network upgrade to accommodate MEV interaction.
ethereum.engine.v1.ExecutionPayloadHeaderDeneb execution_payload_header = 10;

// At most MAX_BLS_TO_EXECUTION_CHANGES. New in Deneb network upgrade.
// At most MAX_BLS_TO_EXECUTION_CHANGES. New in Capella network upgrade.
repeated SignedBLSToExecutionChange bls_to_execution_changes = 11 [(ethereum.eth.ext.ssz_max) = "16"];

repeated bytes blob_kzg_commitments = 12 [(ethereum.eth.ext.ssz_size) = "?,48", (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size"];
Expand Down
2 changes: 1 addition & 1 deletion proto/ssz_proto_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ mainnet = {
"sync_committee_aggregate_bytes.size": "16",
"sync_committee_aggregate_bits.type": "github.com/prysmaticlabs/go-bitfield.Bitvector128",
"withdrawal.size": "16",
"blob.size": "131072",
"blob.size": "131072", # BYTES_PER_FIELD_ELEMENT * FIELD_ELEMENTS_PER_BLOB
"logs_bloom.size": "256",
"extra_data.size": "32",
"max_blobs_per_block.size": "6",
Expand Down
Loading