Beacon API: get blob fix retention cases #13585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Bug
james-prysm
commented
Feb 5, 2024
| @@ -207,7 +215,25 @@ func (p *BeaconDbBlocker) Blobs(ctx context.Context, id string, indices []uint64 | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if !p.BeaconDB.HasBlock(ctx, bytesutil.ToBytes32(root)) { | |||
There was a problem hiding this comment.
maybe this isn't needed if i just use p.BeaconDB.Block()
james-prysm
changed the title
rkapka
requested changes
Feb 6, 2024
| moc := &mockChain.ChainService{FinalizedCheckPoint: ð.Checkpoint{Root: blockRoot[:]}} | ||
| blocker := &lookup.BeaconDbBlocker{ | ||
| ChainInfoFetcher: moc, | ||
| GenesisTimeFetcher: moc, // max slot |
There was a problem hiding this comment.
What is the meaning of the max slot comment? I don't think genesis time is set to max slot - it's set to zero.
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
fixes the /eth/v1/beacon/blob_sidecars/{block_id} endpoint to handl the additional cases below correctly without a 500 error. currently, we will try to use the root even if the block doesn't exist which doesn't correctly handle all our cases.
block exists, no commitment, 200 w/ empty list
block exists, has commitments, inside retention period (greater of protocol- or user-specified) serve then w/ 200 unless we hit an error reading them. we are technically not supposed to import a block to forkchoice unless we have the blobs, so the nuance here is if we can't find the file and we are inside the protocol-defined retention period, then it's actually a 500.
Which issues(s) does this PR fix?
related to #13134