db/blobs: Check non-zero data is written to disk #13647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@terencechain Not really... These kind of errors are things that could be very unexpected. This PR aims to address some "impossible" cases with more verbose errors to assist with ruling out some potential issues. This PR with #13648 would make blob saving more resilient |
kasey
approved these changes
Feb 21, 2024
terencechain
approved these changes
Feb 21, 2024
prestonvanloon
added a commit
that referenced
this pull request
Feb 21, 2024
(cherry picked from commit daad29d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* blob save: add better data checking for empty blob issues (#13647) (cherry picked from commit daad29d) * avoid part path collisions with mem addr entropy (#13648) * avoid part path collisions with mem addr entropy * Regression test --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> (cherry picked from commit 4c66e4d) * fix error race --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> Co-authored-by: kasey <489222+kasey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Add some error returning paths when the following bad things happen:
Which issues(s) does this PR fix?
We've found empty blob files on disk and this PR aims to prevent that scenario.
Other notes for review