p2p: Increase pubsub message seen TTL from 120s to two epochs #14030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested changes
May 22, 2024
There was a problem hiding this comment.
This PR is unnecessary, we already set this here:
https://github.com/prysmaticlabs/prysm/blob/develop/beacon-chain/p2p/pubsub.go#L29
|
The log issue has been fixed in an earlier PR: However, we have not had a release for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Since attestations are valid for two epochs, it is more appropriate to maintain a history of these
seen messages for two epochs so that Prysm is not redundantly sending valid attestations through the
network.
Which issues(s) does this PR fix?
Other notes for review
This matches Lighthouse's configuration
This PR also changes the log level of expired attestations to debug since it was occuring so often
during my testing and some users have reported it.
Default: https://github.com/libp2p/go-libp2p-pubsub/blob/dbd1c9eadedc402fa40ba3e45296594d7e828110/pubsub.go#L32