Move back ConvertKzgCommitmentToVersionedHash to primitives package #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
previously approved these changes
Oct 7, 2024
terencechain
previously approved these changes
Oct 7, 2024
james-prysm
previously approved these changes
Oct 7, 2024
potuz
force-pushed
the
restore_to_primitive
branch
from
a677731 to
57b2ef3
Compare
james-prysm
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exporting functions in the blockchain package makes them very difficult to be used as not that many packages have access to the blockchain package due to circular dependencies. This PR moves one of them to the primitives package. It breaks a dependency circle on ePBS.