Make State Requests only Request for Finalized State #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
rauljordan,
0xKiwi,
prestonvanloon and
terencechain
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
========================================
- Coverage 71.99% 71.6% -0.4%
========================================
Files 109 108 -1
Lines 8353 8099 -254
========================================
- Hits 6014 5799 -215
+ Misses 1773 1759 -14
+ Partials 566 541 -25 |
beacon-chain/blockchain/service.go
Outdated
| } | ||
|
|
||
| // Forward processed block to operation pool to remove individual operation from DB. | ||
| c.opsPoolService.IncomingProcessedBlockFeed().Send(block) |
There was a problem hiding this comment.
Please log an error if this returns 0, it means you sent a message to no one
beacon-chain/blockchain/service.go
Outdated
| @@ -426,6 +438,14 @@ func (c *ChainService) isBlockReadyForProcessing(block *pb.BeaconBlock, beaconSt | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *ChainService) checkLastFinalizedEpoch(beaconState *pb.BeaconState) error { | |||
There was a problem hiding this comment.
Can you add a better method name? This doesn’t describe the behavior of the method
rauljordan
approved these changes
Mar 11, 2019
prestonvanloon
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write why you are making the changes in this pull request.
Our sync were requesting the current state when we should have been requesting the
last finalized state.
Write a summary of the changes you are making.
validator's indexes if the epoch transition happened when a non nil block was given.
current state root..