Change BLS Pairing Engine #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestonvanloon
requested changes
Sep 30, 2019
prestonvanloon
requested changes
Sep 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #3670 +/- ##
===========================================
- Coverage 53.04% 35.92% -17.12%
===========================================
Files 172 5 -167
Lines 11197 309 -10888
===========================================
- Hits 5939 111 -5828
+ Misses 4407 187 -4220
+ Partials 851 11 -840 |
rauljordan
previously approved these changes
Oct 1, 2019
prestonvanloon
requested changes
Oct 1, 2019
shared/bls/bls.go
Outdated
| } | ||
|
|
||
| // PublicKeyFromBytes creates a BLS public key from a LittleEndian byte slice. | ||
| func PublicKeyFromBytes(pub []byte) (*PublicKey, error) { | ||
| if featureconfig.FeatureConfig().SkipBLSVerify { | ||
| return &PublicKey{}, nil | ||
| } | ||
| cv := pubkeyCache.Get(string(pub)) |
There was a problem hiding this comment.
Why remove this? This method was called in high frequency with infrequently changing parameters. Aligning the bytes to the curve was expensive.
shared/bls/bls.go
Outdated
| } | ||
|
|
||
| // Copy the public key to a new pointer reference. | ||
| // Copy copies the public key and returns it. |
There was a problem hiding this comment.
Can you revert this comment?
Suggested change
| // Copy copies the public key and returns it. | |
| // Copy the public key to a new pointer reference. |
prestonvanloon
approved these changes
Oct 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes current BLS pairing engine to the new engine and speeds up signature verification process by 3x.
While BLS signature and keys API remains as is, only underlying math library is changed.
For now, ‘try and increment’ method for hash to G2 is considered. Standart hash method will be added soon after BLS standardization is finalized.
x86 assembly code is generated using github.com/kilic/fp libary
This new pairing engine library processes single pairing in ~2.4ms. Such performance is comparable to rust implementation.