Refactor constructors to remove default nullptr parent parameter and …

…add overloads.
przemek83 · Jan 14, 2025 · 1cf337b · 1cf337b
1 parent c5f5761
commit 1cf337b
Show file tree

Hide file tree

Showing 14 changed files with 33 additions and 8 deletions.
diff --git a/include/qwtble/BasicDataPlot.h b/include/qwtble/BasicDataPlot.h
@@ -17,7 +17,8 @@ class QWTBLE_EXPORT BasicDataPlot : public PlotBase
 {
     Q_OBJECT
 public:
-    explicit BasicDataPlot(QWidget* parent = nullptr);
+    explicit BasicDataPlot(QWidget* parent);
+    BasicDataPlot();
 
     ~BasicDataPlot() override;
 

diff --git a/include/qwtble/GroupPlot.h b/include/qwtble/GroupPlot.h
@@ -13,7 +13,8 @@ class QWTBLE_EXPORT GroupPlot : public PlotBase
 {
     Q_OBJECT
 public:
-    explicit GroupPlot(QWidget* parent = nullptr);
+    explicit GroupPlot(QWidget* parent);
+    GroupPlot();
 
     ~GroupPlot() override;
 

diff --git a/include/qwtble/GroupPlotUI.h b/include/qwtble/GroupPlotUI.h
@@ -24,8 +24,10 @@ class QWTBLE_EXPORT GroupPlotUI : public QWidget
 {
     Q_OBJECT
 public:
-    explicit GroupPlotUI(const QVector<std::pair<QString, int> >& stringColumns,
-                         QWidget* parent = nullptr);
+    GroupPlotUI(const QVector<std::pair<QString, int> >& stringColumns,
+                QWidget* parent);
+    explicit GroupPlotUI(
+        const QVector<std::pair<QString, int> >& stringColumns);
 
     ~GroupPlotUI() override;
 

diff --git a/include/qwtble/HistogramPlot.h b/include/qwtble/HistogramPlot.h
@@ -17,7 +17,8 @@ class QWTBLE_EXPORT HistogramPlot : public PlotBase
 {
     Q_OBJECT
 public:
-    explicit HistogramPlot(QWidget* parent = nullptr);
+    explicit HistogramPlot(QWidget* parent);
+    HistogramPlot();
 
     ~HistogramPlot() override;
 

diff --git a/include/qwtble/HistogramPlotUI.h b/include/qwtble/HistogramPlotUI.h
@@ -20,7 +20,8 @@ class QWTBLE_EXPORT HistogramPlotUI : public QWidget
 {
     Q_OBJECT
 public:
-    explicit HistogramPlotUI(QWidget* parent = nullptr);
+    explicit HistogramPlotUI(QWidget* parent);
+    HistogramPlotUI();
 
     ~HistogramPlotUI() override;
 

diff --git a/include/qwtble/PlotBase.h b/include/qwtble/PlotBase.h
@@ -17,7 +17,8 @@ class QWTBLE_EXPORT PlotBase : public QwtPlot
 {
     Q_OBJECT
 public:
-    explicit PlotBase(const QString& title, QWidget* parent = nullptr);
+    PlotBase(const QString& title, QWidget* parent);
+    explicit PlotBase(const QString& title);
 
     ~PlotBase() override;
 

diff --git a/include/qwtble/QuantilesPlot.h b/include/qwtble/QuantilesPlot.h
@@ -15,7 +15,8 @@ class QWTBLE_EXPORT QuantilesPlot : public PlotBase
 {
     Q_OBJECT
 public:
-    explicit QuantilesPlot(QWidget* parent = nullptr);
+    explicit QuantilesPlot(QWidget* parent);
+    QuantilesPlot();
 
     ~QuantilesPlot() override;
 

diff --git a/src/BasicDataPlot.cpp b/src/BasicDataPlot.cpp
@@ -24,6 +24,8 @@ BasicDataPlot::BasicDataPlot(QWidget* parent)
     checkLegendItems();
 }
 
+BasicDataPlot::BasicDataPlot() : BasicDataPlot(nullptr) {}
+
 BasicDataPlot::~BasicDataPlot() = default;
 
 void BasicDataPlot::initPlotCurve()

diff --git a/src/GroupPlot.cpp b/src/GroupPlot.cpp
@@ -26,6 +26,8 @@ GroupPlot::GroupPlot(QWidget* parent)
     setAxisFont(QwtPlot::xBottom, font);
 }
 
+GroupPlot::GroupPlot() : GroupPlot(nullptr) {}
+
 // Uncommon construction to allow forward declaration of YAxisNumberPicker.
 GroupPlot::~GroupPlot() = default;
 

diff --git a/src/GroupPlotUI.cpp b/src/GroupPlotUI.cpp
@@ -30,6 +30,11 @@ GroupPlotUI::GroupPlotUI(const QVector<std::pair<QString, int> >& stringColumns,
             &GroupPlotUI::updateQuantilesPlotExtent);
 }
 
+GroupPlotUI::GroupPlotUI(const QVector<std::pair<QString, int> >& stringColumns)
+    : GroupPlotUI(stringColumns, nullptr)
+{
+}
+
 GroupPlotUI::~GroupPlotUI() = default;
 
 void GroupPlotUI::setNewData(const QVector<QString>& intervalsNames,

diff --git a/src/HistogramPlot.cpp b/src/HistogramPlot.cpp
@@ -17,6 +17,8 @@ HistogramPlot::HistogramPlot(QWidget* parent)
     initLegend();
 }
 
+HistogramPlot::HistogramPlot() : HistogramPlot(nullptr) {}
+
 // Uncommon construction to allow forward declaration of XYAxisNumberPicker.
 HistogramPlot::~HistogramPlot() = default;
 

diff --git a/src/HistogramPlotUI.cpp b/src/HistogramPlotUI.cpp
@@ -17,6 +17,8 @@ HistogramPlotUI::HistogramPlotUI(QWidget* parent)
             &histogramPlot_, &HistogramPlot::recompute);
 }
 
+HistogramPlotUI::HistogramPlotUI() : HistogramPlotUI(nullptr) {}
+
 HistogramPlotUI::~HistogramPlotUI() = default;
 
 void HistogramPlotUI::setNewData(QVector<double> data,

diff --git a/src/PlotBase.cpp b/src/PlotBase.cpp
@@ -28,6 +28,8 @@ PlotBase::PlotBase(const QString& title, QWidget* parent)
     setAxisLabelAlignment(QwtPlot::xBottom, Qt::AlignLeft | Qt::AlignBottom);
 }
 
+PlotBase::PlotBase(const QString& title) : PlotBase(title, nullptr) {}
+
 // Uncommon construction to allow forward declaration of PlotMagnifier class.
 PlotBase::~PlotBase() = default;
 

diff --git a/src/QuantilesPlot.cpp b/src/QuantilesPlot.cpp
@@ -28,6 +28,8 @@ QuantilesPlot::QuantilesPlot(QWidget* parent)
     setupLegend(width());
 }
 
+QuantilesPlot::QuantilesPlot() : QuantilesPlot(nullptr) {}
+
 // Uncommon construction to allow forward declaration of YAxisNumberPicker.
 QuantilesPlot::~QuantilesPlot() = default;