Don't omit Xms Java opt #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @drunkensway this build error occurs because -Xms (the minimum heap size) is expected to exist as the `$XMS_VALUE` environment variable in java_agent/memoryConfig.sh: line 90. This is mentioned in Java Memory Agent itself here: https://github.com/jelastic-jps/java-memory-agent#java-memory-agent-add-on-specific Interestingly we do set Xms in .jvmopts but these seemingly aren't used inside of docker compose for example. Hence the error I observed when trying to run the latest Hydra image version (31, although the version numbers are very confusing): ``` 2023-11-30 18:23:11 /java_agent/memoryConfig.sh: line 90: [[: 2 2023-11-30 18:23:11 2: syntax error in expression (error token is "2") ``` The code in question is: ``` [[ $XMS_VALUE -ge $XMX_VALUE ]] && XMS=${XMX_VALUE}M ``` Also here: https://github.com/jelastic-jps/java-memory-agent/blob/7fdd2996319d010ac0746b0351971fbe4c752e72/scripts/memoryConfig.sh#L91 As you can see there's an expectation that the $XMS_VALUE is always set. After supplying this env var to the hydra docker image in my docker-compose.yml, everything worked fine: ``` JAVA_OPTS: "-Xmx2G -Xms1G" ```
drunkensway
approved these changes
Dec 4, 2023
|
@drunkensway Tests failed but honestly not sure why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @drunkensway on Slack this build error occurs because -Xms (the minimum heap size) is expected to exist as the
$XMS_VALUEenvironment variable injava_agent/memoryConfig.sh: line 90.
This is mentioned in Java Memory Agent itself here: https://github.com/jelastic-jps/java-memory-agent#java-memory-agent-add-on-specific
Interestingly we do set Xms in .jvmopts but these seemingly aren't used inside of docker compose for example. Hence the error I observed when trying to run the latest Hydra image version (31, although the version numbers are very confusing):
The code in question is:
Also here: https://github.com/jelastic-jps/java-memory-agent/blob/7fdd2996319d010ac0746b0351971fbe4c752e72/scripts/memoryConfig.sh#L91
As you can see there's an expectation that the $XMS_VALUE is always set.
After supplying this env var to the hydra docker image in my docker-compose.yml, everything worked fine: