Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gh action linter #68

Merged
merged 1 commit into from
Oct 19, 2024
Merged

feat: add gh action linter #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,12 @@ jobs:

- name: Build Docker Image
run: |
docker build -t docker.io/psadi/bbcli:${{ steps.meta.outputs.tags || github.sha }} .
docker build -t docker.io/psadi/bbcli:${{ github.event.release.tag_name || github.sha }} .

- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@0.20.0
with:
image-ref: docker.io/psadi/bbcli:${{ steps.meta.outputs.tags || github.sha }}
image-ref: docker.io/psadi/bbcli:${{ github.event.release.tag_name || github.sha }}
format: "sarif"
output: "trivy-results.sarif"
exit-code: "1"
Expand All @@ -159,4 +159,4 @@ jobs:
- name: Push Docker Image
if: ${{ github.event_name == 'release' }}
run: |
docker push docker.io/psadi/bbcli:${{ steps.meta.outputs.tags || github.sha }}
docker push docker.io/psadi/bbcli:${{ github.event.release.tag_name }}
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,7 @@ repos:
- id: pdm-export
args: ["-o", "requirements.txt", "--without-hashes"]
files: ^pdm.lock$
- repo: https://github.com/rhysd/actionlint
rev: v1.7.3
hooks:
- id: actionlint-system
2 changes: 1 addition & 1 deletion config.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@

[auth]
; Dummu local hostname
bitbucket_host = https://bb.picolo.co.in
bitbucket_host = https://bitbucket.org.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Incorrect Bitbucket URL Still Present

The incorrect Bitbucket URL https://bitbucket.org.com is still found in config.ini. Please update it to https://bitbucket.org to ensure proper connectivity.

🔗 Analysis chain

Incorrect Bitbucket URL

The new Bitbucket URL https://bitbucket.org.com appears to be incorrect. The standard Bitbucket URL is https://bitbucket.org. Please verify and update the URL accordingly.

Apply this diff to fix the URL:

-bitbucket_host = https://bitbucket.org.com
+bitbucket_host = https://bitbucket.org

To ensure this change doesn't affect other parts of the codebase, please run the following script:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for occurrences of the incorrect Bitbucket URL

# Test: Search for the incorrect URL. Expect: No results.
rg --type-add 'config:*.{ini,yaml,yml,json}' --type config 'https://bitbucket.org.com'

# Test: Search for the correct URL. Expect: At least one result in config.ini.
rg --type-add 'config:*.{ini,yaml,yml,json}' --type config 'https://bitbucket.org'

Length of output: 277

username = xxxxxxxx
token = xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Loading