Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Stubs #105

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Connection Stubs #105

merged 2 commits into from
Nov 22, 2021

Conversation

timglabisch
Copy link
Contributor

@timglabisch timglabisch commented Nov 22, 2021

see #104

Fixes #104

@timglabisch
Copy link
Contributor Author

holy shit, it seems that there are still missing a bunch of methods.

fetchAllAssociative
fetchAllNumeric
fetchAll
executeQuery
fetchAllKeyValue
fetchAllAssociativeIndexed
fetchFirstColumn
iterateNumeric
iterateAssociative
iterateKeyValue
iterateAssociativeIndexed
iterateColumn
executeQuery
executeCacheQuery
project

may someone who is more involved in this project could look at this, too?

@timglabisch
Copy link
Contributor Author

it seems that the failing tests are not related to this pr?

@timglabisch
Copy link
Contributor Author

there are also more changes.
for example

string $query changed to string $sql
https://github.com/doctrine/dbal/blob/4.0.x/src/Connection.php#L945

it also was just $query (https://github.com/doctrine/dbal/blob/c2b8e6e82732a64ecde1cddf9e1e06cb8556e3d8/lib/Doctrine/DBAL/Connection.php#L1043) and just $sql .

@timglabisch timglabisch changed the title Connection::executeStatement Stubs Connection Stubs Nov 22, 2021
@orklah orklah merged commit 089d10e into psalm:2.x Nov 22, 2021
@orklah
Copy link
Collaborator

orklah commented Nov 22, 2021

Thanks!

Unfortunately, we're kind of short in maintainer that use Doctrine regularly so we're limited to accepting PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taint Sink connection->executeStatement is missing
2 participants