Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-str keys when sending commands #214

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Handle non-str keys when sending commands #214

merged 2 commits into from
Dec 29, 2023

Conversation

bdraco
Copy link

@bdraco bdraco commented Dec 29, 2023 •
edited
Loading

Keys may be subclassed str which are rejected by default unless orjson.OPT_NON_STR_KEYS is enabled

fixes home-assistant/core#105323

@bdraco bdraco marked this pull request as ready for review December 29, 2023 19:30
@bdraco bdraco mentioned this pull request Dec 29, 2023
Closed
@pschmitt
Copy link
Owner

thx

@pschmitt pschmitt merged commit dd43f24 into pschmitt:main Dec 29, 2023
3 of 7 checks passed
@bdraco bdraco deleted the orjson_str_key_fix branch December 29, 2023 20:36
@bdraco
Copy link
Author

bdraco commented Dec 29, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dict key must be str when sending parameters
2 participants
@bdraco @pschmitt