Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #229

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Fix CI #229

merged 5 commits into from
Feb 15, 2024

Conversation

Orhideous
Copy link
Collaborator

No description provided.

@Orhideous
Copy link
Collaborator Author

E OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 8883): address already in use

I think there is a need for randomisation of ports to run tests simultaneously.

@Orhideous Orhideous marked this pull request as draft February 14, 2024 11:36
@Orhideous Orhideous marked this pull request as ready for review February 14, 2024 22:41
@Orhideous
Copy link
Collaborator Author

Orhideous commented Feb 14, 2024 •
edited
Loading

Well, it works now. I moved the tests from the rather unstable amqtt to mosquitto. In subsequent PRs, I'll split tests for unit and integration.

P.S. This PR supersedes #185

@pschmitt
Copy link
Owner

Thanks a lot ❤️

@pschmitt pschmitt merged commit 6cdf5a8 into pschmitt:main Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orhideous @pschmitt