Update to paho-mqtt 2.1.0 #405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
|
It might be possible to allow the paho client to be >= 1.6.1 and <=3.00. This way it does not break fro users that still depend on the old client. For example: Python-roborock/python-roborock#288 |
|
Good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i wanna help get this PR in home-assistant get done.
home-assistant/core#136130
As far as i understand the paho-mqtt documentation, bumping the version and adding CallbackAPIVersion.Version1, when creating the Client object should be enough.
https://eclipse.dev/paho/files/paho.mqtt.python/html/migrations.html
You might want to remove types-paho-mqtt, because it isnt needed anymore.
https://pypi.org/project/types-paho-mqtt/1.6.0.20240321/
I cant test this, because i dont own a roomba.
Thank you.