Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All tests are run against python2 optional dependency #2166

Closed
KotlinIsland opened this issue Apr 29, 2021 · 1 comment
Closed

All tests are run against python2 optional dependency #2166

KotlinIsland opened this issue Apr 29, 2021 · 1 comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases

Comments

@KotlinIsland
Copy link
Contributor

There is also no coverage of:

  • negative scenario of formatting python2 code without python2 optional dependency
@KotlinIsland KotlinIsland added the T: bug Something isn't working label Apr 29, 2021
@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label Apr 29, 2021
@KotlinIsland KotlinIsland mentioned this issue May 4, 2021
Merged
@ichard26 ichard26 removed the T: bug Something isn't working label May 4, 2021
@ichard26
Copy link
Collaborator

ichard26 commented May 4, 2021

Closing since this has been resolved by GH-2190 which has been merged. @KotlinIsland thank you for noticing and submitting a fix!

@ichard26 ichard26 closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ichard26 @KotlinIsland