Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test configuration that doesn't contain python2 optional install #2190

Merged
merged 1 commit into from
May 4, 2021
Merged

Add test configuration that doesn't contain python2 optional install #2190

merged 1 commit into from
May 4, 2021

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented May 4, 2021 •
edited
Loading

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label May 4, 2021
@KotlinIsland
add test configurations that don't contain python2 optional install
a281cba 
add test for negative scenario: formatting python2 code
tag python2 only tests
@KotlinIsland
Copy link
Contributor Author

I don't think the changelog check is working.

@JelleZijlstra
Copy link
Collaborator

@KotlinIsland what do you think is wrong with it?

@KotlinIsland
Copy link
Contributor Author

@KotlinIsland what do you think is wrong with it?

I didn't add anything to the changelog and the pipeline passed

@JelleZijlstra
Copy link
Collaborator

That's because I added the skip news label. Test-only changes don't need a changelog.

@KotlinIsland
Copy link
Contributor Author

Ohhhhhhhhhhhhhhhhhhhh, coolcoolcool

@ambv ambv merged commit 204f76e into psf:master May 4, 2021
@ichard26 ichard26 added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label May 4, 2021
@ichard26 ichard26 mentioned this pull request May 4, 2021
Closed
@ambv ambv mentioned this pull request May 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KotlinIsland @JelleZijlstra @ambv @ichard26