-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't max-line-length be 80 when using bugbear? #3716
Comments
I think here our intention was just to "be safe" for people not running bugbear as well who copy paste. Reading is hard. At the end of the day we just want flake8 to not bother warning black enabled repositories about the line length, as, after all, you're using an autoformatter and you shouldn't ever hit the line lint warning ... Happy to discuss further, but I think for people not reading and parsing that flake8-bugbear does this we might get some people who copy paste and wonder what is going on. I would be down to add this context to the docs tho, leaving the default if you think that helps. |
Perhaps the phrasing can be improved to be more explicit about this? It's currently very open and suggestive. Black is supposed to be opinionated and uncompromising, is it not? ;) Suggested, more concise text:
|
Sure feel free to make a PR of making it more concise. Easier for people to comment there. |
* Make phrasing for flake8 users more concise max-line-length should be 80 with flake8-bugbear Fixes #3716 * Re-add rationale and an explanation for disabling E203 * Run pre-commit
Is this related to a problem? Please describe.
The documentation suggests using
flake8-bugbear
instead of just bumpingmax-line-length
to 88, as bugbear already handles a line max 10% longer thanmax-line-length
. However, the example with bugbear below it still uses 88.What this effectively means is that flake8 (with bugbear) won't complain about lines up to 96 characters long.
I think the example value should be 80:
The text was updated successfully, but these errors were encountered: