-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies for black[d]
are being installed by default
#4107
Comments
Good catch, thanks! Seems like a bug in hatch? We should still presumably work around it by adding parentheses, though. |
Although probably unrelated cause (they use poetry) |
@JelleZijlstra Will there be a |
Jelle's unavailable. I'll try to make a release in the next few days (but I haven't cut a Black release before / am currently travelling, so it'll happen when it happens) |
I can cut one now if people want and am around to try help if things fail. |
imho it should be fixed asap because it makes latest black impossible to install on Python 3.12. This is because multidict<7 is incompatible with 3.12. It will yield this error:
|
This reverts gitpython-developers#1766. Black 23.12.1 has been released. This has the fix for the issue that kept GitPython's test dependencies from being installed on Cygwin. - psf/black#4107 - https://github.com/psf/black/releases/tag/23.12.1 - https://pypi.org/project/black/23.12.1/
Thanks to cooperlees, 23.12.1 is now a thing! |
Happy Holidays! |
Describe the bug
Minor bug, but it seems that the extra dependencies for the
d
extra are being installed by default on 23.12.0. This can cause some issues on docker containers and such wheregcc
isn't installed, as the extra dependencies (aiohttp
, andfrozenlist
) don't seem to have wheels.To Reproduce
On a non-windows machine (I've done it on Ubuntu, and it also seems to happen on Linux github action runners) Make a new venv, source it, and install black:
python3 -m venv .venv source .venv/bin/activate pip install black
It will install requirements from the
d
extra as well;Expected behavior
It shouldn't install with the
aiohttp
,frozenlist
, andmultidict
dependencies.Environment
Additional context
First seen in rickstaa/action-black#18
I think it has to do with: 85b1c71; in my pip logs, the new restrictions seem to show up as:
i.e., the
extra == "d"
is ignored in favor of the sys platform not being windows, so the extras are always installed. I think a quick fix would be to wrap the extras in parenthesis. Happy to make a quick PR for that.The text was updated successfully, but these errors were encountered: