Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please don't move tags #760

Closed
djmitche opened this issue Mar 15, 2019 · 3 comments
Closed

Please don't move tags #760

djmitche opened this issue Mar 15, 2019 · 3 comments
Labels
C: packaging Installation and packaging of Black

Comments

@djmitche
Copy link

When updating the repo:

Failed to download remote objects and refs:  From https://github.com/ambv/black
   ea55ff2..d6db1c1  master     -> origin/master
 * [new tag]         19.3b0     -> 19.3b0
 ! [rejected]        stable     -> stable  (would clobber existing tag)

I assume that stable is meant to track the latest stable release? That's a job for a branch, not a tag :)
@JelleZijlstra JelleZijlstra added the C: packaging Installation and packaging of Black label May 5, 2019
@ambv
Copy link
Collaborator

ambv commented Mar 3, 2020

OK, we will remove the "stable" tag and make it a branch with the next release.

@ambv
Copy link
Collaborator

ambv commented Mar 4, 2020

OK, this is solved. stable is no longer a tag, it is a branch.

@ambv ambv closed this as completed Mar 4, 2020
@sersorrel
Copy link
Contributor

fwiw, this goes directly against a statement in the pre-commit documentation:

pre-commit assumes that the value of rev is an immutable ref (such as a tag or SHA) and will cache based on that. Using a branch name (or HEAD) for the value of rev is not supported and will only represent the state of that mutable ref at the time of hook installation (and will NOT update automatically).

@hugovk hugovk mentioned this issue May 1, 2020
Closed
@ichard26 ichard26 mentioned this issue May 17, 2020
Merged
ichard26 added a commit to ichard26/black that referenced this issue May 17, 2020
@ichard26
Update docs about stable tag now being a branch
750af4e 
Issue psf#760 had the `stable` tag changed to a branch since it was causing a few issues. This updates the docs to reflect that change.
@ichard26 ichard26 mentioned this issue May 17, 2020
Merged
cooperlees pushed a commit that referenced this issue May 17, 2020
@ichard26
Update docs about stable tag now being a branch (#1422)
f62f1dd 
* Update docs about stable tag now being a branch

Issue #760 had the `stable` tag changed to a branch since it was causing a few issues. This updates the docs to reflect that change.

* Make the prettier hook pass

* Improve wording
@ichard26 ichard26 mentioned this issue Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: packaging Installation and packaging of Black
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@djmitche @ambv @JelleZijlstra @sersorrel