Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract formatting tests #1785

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Extract formatting tests #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7cbfba
Update test versions
saroad2 Oct 25, 2020
cd7db60
Use parametrize to remove tests duplications
saroad2 Oct 25, 2020
3b6890d
Extract sources format tests
saroad2 Oct 25, 2020
78e0059
Fix mypy errors
saroad2 Oct 25, 2020
5b7f590
Fix .travis.yml
saroad2 Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ cache:
directories:
- $HOME/.cache/pre-commit
env:
- TEST_CMD="coverage run -m unittest"
- TEST_CMD="tox -e py"
install:
- pip install coverage coveralls pre-commit
- pip install coverage coveralls pre-commit tox
- pip install -e '.[d]'
script:
- $TEST_CMD
Expand Down
9 changes: 5 additions & 4 deletions test_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
pytest >= 6.0.1
pytest-mock >= 3.2.0
pytest-cases >= 2.1.2
coverage >= 5.2.1
pytest >= 6.1.1
pytest-mock >= 3.3.1
pytest-cases >= 2.3.0
coverage >= 5.3
parameterized >= 0.7.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather then adding a new dependency, can @pytest.mark.parametrize be used to do the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can, but it has been requested specifically to avoid using pytest in tests directly in order to allow people to use the testing platform of their choosing.
I personally prefer using pytest at any time, but I respect the design decisions of this project.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main pytest dislike is it's magical patching of thing so I guess the adding of a dep to allow both testing systems to be used works. Especially when this refactor is a big win imo.

Loading