Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump typed-ast to fix for s390x #1892

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Bump typed-ast to fix for s390x #1892

merged 2 commits into from
Dec 31, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 31, 2020

Fixes #1109.

@hugovk hugovk mentioned this pull request Dec 31, 2020
Closed
hauntsaninja
hauntsaninja reviewed Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to change Pipfile as well

@hugovk
Copy link
Contributor Author

hugovk commented Dec 31, 2020

Do I just change the version in Pipfile, or also run a command to update the lock?

@hauntsaninja
Copy link
Collaborator

Try pipenv install typed-ast==1.4.2? It'll do a bunch of other stuff, as pipenv is wont, but that's fine (or at least it was in #1867 )

@hugovk
Copy link
Contributor Author

hugovk commented Dec 31, 2020

Done!

cooperlees
cooperlees approved these changes Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff. Many thanks!

@cooperlees cooperlees merged commit 60de5bb into psf:master Dec 31, 2020
@hugovk hugovk deleted the patch-3 branch December 31, 2020 17:52
noxan pushed a commit to noxan/black that referenced this pull request Jun 6, 2021
@hugovk @noxan
Bump typed-ast to fix for s390x (psf#1892)
2ce3bd8 
* Bump typed-ast to fix for s390x

* pipenv install typed-ast==1.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s390x: test_python2/test_python2_unicode_literals can't assign to () INTERNAL ERROR
3 participants
@hugovk @hauntsaninja @cooperlees