-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return NothingChanged
if non-Python cell magic is detected, to avoid tokenize error
#2630
Commits on Nov 19, 2021
-
Include cell magics in
validate_cell
Let `validate_cell()` also catch non-Python cell magics, as the bodies of these might contain invalid indentation (such as `%%writefile`) and this could cause TransformerManager to break.
Daniel Sparing authoredNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for e97f241 - Browse repository at this point
Copy the full SHA e97f241View commit details -
add test for "badly" indented text file
this should be a valid arbitrary writefile, but before it failed via the tokenizer.
Daniel Sparing authoredNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for c0e9ef8 - Browse repository at this point
Copy the full SHA c0e9ef8View commit details -
Daniel Sparing committed
Nov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for dbf3e55 - Browse repository at this point
Copy the full SHA dbf3e55View commit details -
Daniel Sparing committed
Nov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 40d3431 - Browse repository at this point
Copy the full SHA 40d3431View commit details -
add non-Python note and changelog
Daniel Sparing committedNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 80788ef - Browse repository at this point
Copy the full SHA 80788efView commit details -
add note in documentation that non-Python cell magics are skipped too
Daniel Sparing committedNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 00fb86b - Browse repository at this point
Copy the full SHA 00fb86bView commit details -
flip validate_cell cell magics for allowlist
and remove later unnecessary check
Daniel Sparing committedNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 8994c9e - Browse repository at this point
Copy the full SHA 8994c9eView commit details -
replace %t with %timeit in test
as we are now allowlisting python cell magics and %t would be a user-defined custom one
Daniel Sparing committedNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for f12e58d - Browse repository at this point
Copy the full SHA f12e58dView commit details -
added further python cell magics
Daniel Sparing committedNov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 858a7c1 - Browse repository at this point
Copy the full SHA 858a7c1View commit details -
Daniel Sparing committed
Nov 19, 2021 Configuration menu - View commit details
-
Copy full SHA for 1e8a0b1 - Browse repository at this point
Copy the full SHA 1e8a0b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7448206 - Browse repository at this point
Copy the full SHA 7448206View commit details
Commits on Nov 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1d115f2 - Browse repository at this point
Copy the full SHA 1d115f2View commit details
Commits on Nov 29, 2021
-
Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for aadf7e2 - Browse repository at this point
Copy the full SHA aadf7e2View commit details