Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't colour diff headers white, only bold #2691

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Don't colour diff headers white, only bold #2691

merged 2 commits into from
Dec 15, 2021

Conversation

ichard26
Copy link
Collaborator

Description

So people with light themed terminals can still read 'em. Noticed the issue in GH-2688.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary? -> I have no idea how to test this.
  • Add new / update outdated documentation? -> n/a

@ichard26
Don't colour diff headers white, only bold
36a807d 
So people with light themed terminals can still read 'em.
@ichard26 ichard26 merged commit 3083f44 into psf:main Dec 15, 2021
@ichard26 ichard26 deleted the light-themed-terminals-exist-too branch December 15, 2021 00:32
@ichard26 ichard26 mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichard26 @JelleZijlstra