Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hug power operators if its operands are "simple" #2726

Merged
merged 12 commits into from
Jan 25, 2022
Merged

Hug power operators if its operands are "simple" #2726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
80ba597
Hug power operators with "simple" operands
ichard26 Dec 10, 2021
cd84e5c
Update outdated test data
ichard26 Dec 19, 2021
5e6e8c2
Merge branch 'main' into hug-power-op
ichard26 Dec 19, 2021
45b62ee
Add changelog and documentation
ichard26 Dec 26, 2021
83e9416
Add some comments
ichard26 Dec 31, 2021
b42a01b
Merge branch 'main' into hug-power-op
ichard26 Dec 31, 2021
a4fdf42
I literally added this code to bugbear :p
ichard26 Dec 31, 2021
56cb900
Significantly clean up wording in docs
ichard26 Jan 6, 2022
bd2df7f
Merge branch 'main' into hug-power-op
JelleZijlstra Jan 14, 2022
4fa8be8
Merge branch 'main' into hug-power-op
JelleZijlstra Jan 22, 2022
93ddad3
Merge branch 'main' into hug-power-op
JelleZijlstra Jan 22, 2022
b6e8758
Improve tests and docs, also resolve linting
ichard26 Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
- Tuple unpacking on `return` and `yield` constructs now implies 3.8+ (#2700)
- Unparenthesized tuples on annotated assignments (e.g
`values: Tuple[int, ...] = 1, 2, 3`) now implies 3.8+ (#2708)
- Power operators now "hug" their operands if they're both "simple" (#2726)
- Remove spaces around power operators if both operands are simple (#2726)

### Packaging

Expand Down
4 changes: 2 additions & 2 deletions docs/the_black_code_style/current_style.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,8 @@ multiple lines. This is so that _Black_ is compliant with the recent changes in
style guide, which emphasizes that this approach improves readability.

Almost all operators will be surrounded by single spaces, the only exceptions are unary
operators (`+`, `-`, and `~`), and power operators when both its operands are considered
"simple". For power ops, an operand is considered "simple" if it's only a NAME, numeric
operators (`+`, `-`, and `~`), and power operators when both operands are simple.
For power ops, an operand is considered simple if it's only a NAME, numeric
CONSTANT, or attribute access (chained attribute access is allowed), with or without a
preceding unary operator.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading it through once more, we could also say that the surrounding spaces are removed for unaries and simple powers. Now it just says that they are an exception to the rule.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused, could you elaborate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I missed this: I meant to say that we don't actually say what happens to unaries and powers. We only say that they are an exception to the rule. Maybe something like: "[the only exceptions are unaries and simple pows], for which the spaces are removed."


Expand Down