Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate test and release workflows + add concurrency limit to test + fuzz #3017

Closed
wants to merge 2 commits into from

Conversation

ichard26
Copy link
Collaborator

Description

This makes changes across workflow domains easier (like adding concurrency limits) and overall improves consistency. I plan to submit another PR integrating the mypyc workflow from ichard26/black-mypyc-wheels after this is merged. Here's an example run: https://github.com/ichard26/black/actions/runs/2144614522 (including the mypyc patch)

This is probably best landed with a rebase merge fyi.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary? -> n/a
  • Add / update tests if necessary? -> n/a
  • Add new / update outdated documentation?

This makes changes across workflow domains easier and overall improves
consistency.
@ichard26 ichard26 added skip news Pull requests that don't need a changelog entry. C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Apr 15, 2022
@JelleZijlstra JelleZijlstra self-requested a review April 15, 2022 17:18
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (30bdfdd) to main (7f7673d).


What is this? | Workflow run | diff-shades documentation

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - How do we test this tho?

Want to update bandersnatch to this cause I do have a release I need to do, would rather screw up a bandersnatch release than black :D


It will then use [twine](https://pypi.org/project/twine/) to upload both release formats
to PyPI for general downloading of the _Black_ Python package. This is where
PyPI is where almost all users will get _Black_ from as it is where where
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PyPI is where almost all users will get _Black_ from as it is where where
PyPI is where almost all users will get _Black_ from as it is where

@JelleZijlstra
Copy link
Collaborator

Unfortunately this has a lot of conflicts now, @ichard26 are you able to get back to it?

@cooperlees
Copy link
Collaborator

Unfortunately this has a lot of conflicts now, @ichard26 are you able to get back to it?

If not, please just say so and I'll try find time to do this + other release / CI related things in the coming weeks.

@ichard26
Copy link
Collaborator Author

#3189, #3190, and #3197 cover the majority of this PR. Documentation updates will come later.

@ichard26 ichard26 closed this Jul 30, 2022
@ichard26 ichard26 deleted the consolidate-workflows branch July 30, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants