Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed need for subprocess call in action.yml #3226

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Removed need for subprocess call in action.yml #3226

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b54370f
Removed need for subprocess in action.yml
ionite34 Aug 15, 2022
c6db697
Removed changelog entry for #3226
ionite34 Aug 26, 2022
e142646
Update AUTHORS.md
ionite34 Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
- Vim plugin: prefix messages with `Black: ` so it's clear they come from Black (#3194)
- Docker: changed to a /opt/venv installation + added to PATH to be available to
non-root users (#3202)
- GitHub Action: Updated usage of $GITHUB_ACTION_PATH to remove the nested python
ionite34 marked this conversation as resolved.
Show resolved Hide resolved
subprocess call for actions/main.py (#3226)

### Output

Expand Down
19 changes: 2 additions & 17 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,25 +29,10 @@ runs:
using: composite
steps:
- run: |
# Exists since using github.action_path + path to main script doesn't work because bash
# interprets the backslashes in github.action_path (which are used when the runner OS
# is Windows) destroying the path to the target file.
#
# Also semicolons are necessary because I can't get the newlines to work
entrypoint="import sys;
import subprocess;
from pathlib import Path;

MAIN_SCRIPT = Path(r'${GITHUB_ACTION_PATH}') / 'action' / 'main.py';

proc = subprocess.run([sys.executable, str(MAIN_SCRIPT)]);
sys.exit(proc.returncode)
"

if [ "$RUNNER_OS" == "Windows" ]; then
echo $entrypoint | python
python $GITHUB_ACTION_PATH/action/main.py
else
echo $entrypoint | python3
python3 $GITHUB_ACTION_PATH/action/main.py
fi
env:
# TODO: Remove once https://github.com/actions/runner/issues/665 is fixed.
Expand Down