-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix license metadata to follow PEP 621 #3326
Conversation
I would imagine this is not worthy of a changelog entry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Feel free to add yourself to the AUTHORS list :)
Fixed formatting and updated authors list. :) |
JFTR, a plain SPDX id is part of the hopefully as-good-as-passed PEP 639 that Hatch already implements. Technically, the new metadata is wrong-ish, because it’s supposed to be the license, not the license ID. That’s not very useful tho (and clutters the PyPI view), so nobody does it (including myself) and hence PEP 639. All that to say: this should be reverted once PEP 639 passes. ;) |
Neat! When that gets accepted, will PEP621 get updated with the new information, or at least a link to PEP639?
I agree with this sentiment, however, I originally found this because some of our tooling supporting PEP 621 was broken by this metadata. It would be nice to at least give some amount of time for tooling to catch up to PEP 639 before adopting that new format. 😅 |
One would hope! Currently it does refer to it in nebulous terms:
Yeah my editor is unhappy too. The Python packaging construction site keeps giving. |
Description
PEP 621 requires the
license
field to be a table with either afile
ortext
key: https://peps.python.org/pep-0621/#licenseThe current value of
license = "MIT"
is not PEP 621 compliant, even though hatchling allows it.