Report all stacktraces in verbose mode #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
stacktrace
branch
from
f37026f
to
b7940eb
Compare
src/black/concurrency.py
Outdated
Comment on lines
174
to
176
| elif task.exception(): | ||
| report.failed(src, str(task.exception())) | ||
| exc = task.exception() | ||
| assert exc is not None |
There was a problem hiding this comment.
Use a walrus so you can avoid the assert?
elif exc := task.exception():
There was a problem hiding this comment.
Oh right, we dropped 3.7
JelleZijlstra
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these were swallowed; make the reporting more as like
black/__init__.py