Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting for if clauses in match-case blocks #4269

Merged
merged 8 commits into from
Mar 16, 2024
Merged

Fix formatting for if clauses in match-case blocks #4269

merged 8 commits into from
Mar 16, 2024

Conversation

rdrll
Copy link
Contributor

@rdrll rdrll commented Mar 9, 2024 •
edited
Loading

Description

Fixes #3793.

Now the if clauses in the case-match blocks will be correctly wrapped with parenthesis.

The previous problem of having redundant parentheses being added to case statement when it's accompanied by an if clause that was too long, like the example mentioned in #3793 discussion, is also resolved.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

diff-shades reports zero changes comparing this PR (c87416a) to main (8332a75).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra self-requested a review March 9, 2024 02:49
JelleZijlstra
JelleZijlstra reviewed Mar 9, 2024
View reviewed changes
src/black/linegen.py Outdated Show resolved Hide resolved
@rdrll rdrll requested a review from JelleZijlstra March 12, 2024 07:52
JelleZijlstra
JelleZijlstra reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/the_black_code_style/future_style.md Outdated Show resolved Hide resolved
src/black/linegen.py Outdated Show resolved Hide resolved
tests/data/cases/pattern_matching_with_if_stmt.py Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
rdrll and others added 3 commits March 13, 2024 00:47
@rdrll @JelleZijlstra
Apply suggestions from code review
2879848 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a12c5a1 
for more information, see https://pre-commit.ci
@rdrll
New tests
c87416a
@rdrll rdrll requested a review from JelleZijlstra March 16, 2024 06:19
@JelleZijlstra JelleZijlstra merged commit f78b157 into psf:main Mar 16, 2024
46 checks passed
@MichaReiser MichaReiser mentioned this pull request Apr 16, 2024
Closed
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
@MichaReiser MichaReiser mentioned this pull request Sep 16, 2024
Open
29 tasks
@MichaReiser MichaReiser mentioned this pull request Oct 23, 2024
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if clauses in match-case blocks aren't reformatted to fit the line width limit
2 participants
@rdrll @JelleZijlstra