gh-174: Support free-threading CPython by disabling psutil related fe… #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @colesbury |
vstinner
reviewed
Mar 5, 2024
pyperf/_utils.py
Outdated
| from shlex import quote as shell_quote # noqa | ||
| from shutil import which | ||
|
|
||
|
|
||
| IS_FREE_THREADING = bool(sysconfig.get_config_var('Py_GIL_DISABLED')) |
There was a problem hiding this comment.
I suggest to remove IS_: just FREE_THREADING.
vstinner
reviewed
Mar 5, 2024
| Version 2.6.3 (2024-03-05) | ||
| --------------------------- | ||
|
|
||
| * Support Free-threading CPython (PEP-703) by disabling psutil related features. |
There was a problem hiding this comment.
Please add a link to the issue.
There was a problem hiding this comment.
The current blocker is pypa/packaging#755, but there's ~3 more steps needed after that too (update packaging in pip, release pip, update pip in CPython).
There was a problem hiding this comment.
The issue describing why pyperf cannot use psutil on a Python Free Threading build.
It's not related to psutil implementation itself, it is more about packaging issue for a while. |
vstinner
reviewed
Mar 5, 2024
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Mar 5, 2024
vstinner
approved these changes
Mar 5, 2024
vstinner
reviewed
Mar 6, 2024
|
@vstinner Would you like to take a look the PR again? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atures