-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with HTTP proxy and accessing localhost - does requests ignore no_proxy? #879
Comments
I have a similar problem where I just want to disable the proxy for certain requests (connecting to internal WebServices that are not available outside our DMZ). After digging through the requests code to find out how proxies are handled and how proxy configuration is loaded I have come up with a work-around to disable the proxy when needed:
How this works, if the proxies parameter is passed to the get (or other http method) it is has any empty entries removed before checking if there are any values still in the dictionary. If the dictionary is empty then the variables are loaded from the environment using the method requests.utils.get_environ_proxies. By including a value in the 'no' key then the proxies parameter is used which includes empty http and https entries thereby disabling the proxy. The method is a bit hacky but does solve the issue. |
By default, r = requests.get('http://www.google.com', config={'trust_env': False})
s = requests.Session(config={'trust_env': False}) You can see everything you can change with the config dictionary here. Hope that helps! |
heya, Hmm, yes, but by the same logic, wouldn't This is meant to be a list of specific hosts for which we don't use the proxy - and it's supported by most *nix HTTP clients, as far as I'm aware
just to pick a few random ones. I don't think it's a case of not trusting the http_proxy variable, but more just having support for the no_proxy variable as well? Cheers, |
Ah, good point well made. I have genuinely never seen the NO_PROXY variable used, so didn't even know about it. In that case, we should probably endeavour to respect it. =) |
Oh, this is interesting! We do actually check for |
In every list of command line http clients there must be curl even if it's a random list :) |
This change is in response to issue psf#879.
Resolved by #945 (hopefully). Next minor release of Requests should have the fix in it. Please let me know if this turns out not to have fixed it for you. |
Hi @Lukasa , I was having this issue with Requests 1.2. After reading this thread, I thought it will go away on upgrading to 2.0.1 (which contains your fix). However, it did not fix it for me.
|
@tanmay9 How are you setting the environment variable in question? |
Neither of these appear to work for me. @timsavage's method does nothing at all and the config= trick results in: TypeError: request() got an unexpected keyword argument 'config' This is python 3.4.0 and requests 2.2.1. I had to resort to @tanmay9's method of setting the no_http environmental. Just FYI. |
Has this been resolved yet? Requests does not appear to respect the |
Hi @natejgardner, this issue is over 3 years old and we’ve added support for portions of NO_PROXY since then. There are still a few quirks that won’t be addressed due to backwards incompatibility until the next major version of Requests, but the basic functionality works. If you’ve found a specific defect, please open a new issue. Thanks! |
Hi,
I have a Django app, exposing a REST API using TastyPie.
I have it running locally using Django's runserver, and I'm trying to access it using Requests.
For some reason though, accessing it with Curl or Firefox works fine:
And on the Django runserver console, I see:
However, when I try to use the Python requests module (http://docs.python-requests.org/en/latest/), I get a 404:
or:
or:
Also, on the Django runserver console, I see:
Notice that runserver prints the whole path in this case, rather than just the part after localhost:8000 - not sure why that is.
We have a HTTP proxy setup in this environment (Microsoft ISA, I believe), which uses authentication (I've put the username/password in the variable itself).
I've set the
no_proxy
environment variable and put localhost and 127.0.0.1 in there.However, requests seems to still be doing something funky with the proxy.
If I actually unset
http_proxy
- requests works fine:So firstly, I'm curious why requests doesn't work with the proxy variable set? And secondly, is there any any way to get it to respect
no_proxy
?Cheers,
Victor
The text was updated successfully, but these errors were encountered: