-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean libmints new
/delete
#2346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm by no means a C++ expert, but the changes look sensible and the code's a lot more readable. The comments are just a couple of clarifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jonathon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always nice to see updates to modern C++ 😄
Yeah, using valgrind will make it easier to find the leak. At one point, we did have it leak free. |
Good to know. Unfortunately, it may be a bit before I can get valgrind working - there are some issues with Francesco's cluster. |
Description
There's a memory leak somewhere in the SCF code. This PR replaces some of the manual memory management with
new
/delete
inlibmints
to cut down the number of places where it could be coming from. (I'd like to start from a zero-leak baseline for DIIS profiling.)I'll probably need to use
valgrind
to track this down further...Checklist
Status